-
-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: bump chartify to v0.10.0 to support OCI registry for adhoc dependencies #238
Conversation
…ndencies Signed-off-by: Tsubasa Nagasawa <toversus2357@gmail.com> This adds OCI registry support for adhoc dependencies. The users can now add their OCI hosted charts as dependencies to helm releases: * Bump chartify version to v0.10.0 * Add an example helmfile to advanced usage section
510af55
to
7141003
Compare
@toVersus Thanks very much, Can you add a test for this. |
@yxxhero This is purely a chartify-side change so I think it isn't unit-testable from within helmfile. Do you think adding an integration test case that depends on an external ocr repo make sense in this case? (Probably it makes our integration test much more unreliable due to any external ocr repo and access to it isn't 100% reliable |
@mumoshu Yes. I agree. |
@mumoshu should we create a release for this feat? |
I'm not sure it is a right choice but we can manage an OCI helm chart on GitHub container registry and use it for our integration tests. xref: https://dev.to/niklasmtj/use-github-container-registry-ghcr-to-host-your-helm-charts-nef |
Follow-up for #238 Signed-off-by: Yusuke Kuoka <ykuoka@gmail.com>
Follow-up for #238 Signed-off-by: Yusuke Kuoka <ykuoka@gmail.com>
Follow-up for #238 Signed-off-by: Yusuke Kuoka <ykuoka@gmail.com>
@yxxhero @toVersus Hey! Would you mind taking a look at #239? It was a long-standing TODO to add more features to the integration test framework so that we could easily write tests for features like this one so here it is. I opted to use a local docker registry instead of a remote one(like GHCR) hoping it might reduce test flakes. |
@mumoshu ok |
Add integration test for #238 with local docker registry as a OCI-based helm chart repo
Signed-off-by: Tsubasa Nagasawa toversus2357@gmail.com
This adds OCI registry support for adhoc dependencies.
The users can now add their OCI hosted charts as dependencies to helm releases:
xref: helmfile/chartify#33