Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bump chartify to v0.10.0 to support OCI registry for adhoc dependencies #238

Merged
merged 1 commit into from
Jul 18, 2022

Conversation

toVersus
Copy link
Contributor

@toVersus toVersus commented Jul 18, 2022

Signed-off-by: Tsubasa Nagasawa toversus2357@gmail.com

This adds OCI registry support for adhoc dependencies.
The users can now add their OCI hosted charts as dependencies to helm releases:

  • Bump chartify version to v0.10.0
  • Add an example helmfile to advanced usage section

xref: helmfile/chartify#33

…ndencies

Signed-off-by: Tsubasa Nagasawa <toversus2357@gmail.com>

This adds OCI registry support for adhoc dependencies.
The users can now add their OCI hosted charts as dependencies to helm releases:

* Bump chartify version to v0.10.0
* Add an example helmfile to advanced usage section
@toVersus toVersus changed the title feat: bump chartify to v0.10.0 to support oci registry for adhoc dependencies feat: bump chartify to v0.10.0 to support OCI registry for adhoc dependencies Jul 18, 2022
@yxxhero
Copy link
Member

yxxhero commented Jul 18, 2022

@toVersus Thanks very much, Can you add a test for this.

@mumoshu
Copy link
Contributor

mumoshu commented Jul 18, 2022

@yxxhero This is purely a chartify-side change so I think it isn't unit-testable from within helmfile. Do you think adding an integration test case that depends on an external ocr repo make sense in this case? (Probably it makes our integration test much more unreliable due to any external ocr repo and access to it isn't 100% reliable

@yxxhero
Copy link
Member

yxxhero commented Jul 18, 2022

@mumoshu Yes. I agree.

@yxxhero yxxhero merged commit a4b914a into helmfile:main Jul 18, 2022
@yxxhero
Copy link
Member

yxxhero commented Jul 18, 2022

@mumoshu should we create a release for this feat?

@toVersus toVersus deleted the feat/bump-chartify-v0.10.0 branch July 18, 2022 08:33
@toVersus
Copy link
Contributor Author

Probably it makes our integration test much more unreliable due to any external ocr repo and access to it isn't 100% reliable

I'm not sure it is a right choice but we can manage an OCI helm chart on GitHub container registry and use it for our integration tests.

xref: https://dev.to/niklasmtj/use-github-container-registry-ghcr-to-host-your-helm-charts-nef

mumoshu added a commit that referenced this pull request Jul 18, 2022
Follow-up for #238

Signed-off-by: Yusuke Kuoka <ykuoka@gmail.com>
mumoshu added a commit that referenced this pull request Jul 18, 2022
Follow-up for #238

Signed-off-by: Yusuke Kuoka <ykuoka@gmail.com>
mumoshu added a commit that referenced this pull request Jul 18, 2022
Follow-up for #238

Signed-off-by: Yusuke Kuoka <ykuoka@gmail.com>
@mumoshu
Copy link
Contributor

mumoshu commented Jul 18, 2022

@yxxhero @toVersus Hey! Would you mind taking a look at #239?

It was a long-standing TODO to add more features to the integration test framework so that we could easily write tests for features like this one so here it is.

I opted to use a local docker registry instead of a remote one(like GHCR) hoping it might reduce test flakes.

@yxxhero
Copy link
Member

yxxhero commented Jul 18, 2022

@mumoshu ok

yxxhero added a commit that referenced this pull request Jul 18, 2022
Add integration test for #238 with local docker registry as a OCI-based helm chart repo
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants