feat: Auto-detect term for coloring helm-diff output #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since helm-diff has added an ability to auto-detect the term to decide if it should output with color or not, helmfile had been defaulted to no-color. This resoloves that, by adding a term-detection logic that is same as helm-diff. As a part of this work, I have also implemented a new global flag `--color`, which is used for forcing color without relying on the term-detection logic implemented in helmfile or explicitly setting the HELM_DIFF_COLOR envvar. I hope it is useful for folks. Ref roboll/helmfile#2043 Signed-off-by: Yusuke Kuoka <ykuoka@gmail.com>
mumoshu
force-pushed
the
auto-detect-term-for-color-diff
branch
from
cc385cd
to
97e0ca7
Compare
|
I would like to have an exclusive validation on |
|
@itscaro Sounds good! |
|
@itscaro I just reread the codebase and it's a bit harder than I thought because there seems no right place to add an exclusiveness validation. The functions like Or perhaps there's maybe a better place to put such validation? Perhaps immediately before initializing App or Run structs? 🤔 WDYT? |
|
Yes we can do some validation before initializing app, maybe around here https://github.com/helmfile/helmfile/blob/f1a250c/main.go#L996-L1011 |
Signed-off-by: Yusuke Kuoka <ykuoka@gmail.com>
mumoshu
force-pushed
the
auto-detect-term-for-color-diff
branch
from
497e229
to
f84ab66
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since helm-diff has added an ability to auto-detect the term to decide if it should output with color or not, helmfile had been defaulted to no-color.
This resoloves that, by adding a term-detection logic that is same as helm-diff.
As a part of this work, I have also implemented a new global flag
--color, which is used for forcing color without relying on the term-detection logic implemented in helmfile or explicitly setting the HELM_DIFF_COLOR envvar. I hope it is useful for folks.Ref roboll/helmfile#2043