Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dockerfile] only use image alpine for compilation, add sops & age to pre-built image, remove helm v2 image #28

Merged
merged 2 commits into from
Apr 8, 2022

Conversation

itscaro
Copy link
Contributor

@itscaro itscaro commented Apr 6, 2022

  • Compilation stage can be the same in all image build (alpine, debian or ubuntu), I propose to use the same compilation stage with alpine then.
  • Separate go.mod go.sum to an instruction might be a good idea to optimise local builds during development
  • Dockerfile.ubuntu builds image with helm v2, which is alread EOL, we can remove this build, IMO
  • Dockerfile.helm3* are no longer used
  • Sops and age might be useful
  • Remove sops installed with pip, it's no longer maintained
  • Lastly I try to harmonize all the installation instructions, we could move out to a file such as provision.sh to avoid duplication of codes

… pre-built image, remove helm v2 image

Signed-off-by: Quan TRAN <account@itscaro.me>
@itscaro itscaro requested a review from mumoshu as a code owner April 6, 2022 09:00
@mumoshu
Copy link
Contributor

mumoshu commented Apr 6, 2022

It would be nice if you could link related issues from roboll/helmfile or write a few lines of description! (Sry if you're already writing it 🙏

@itscaro itscaro force-pushed the qtran/image branch 2 times, most recently from 661e2df to 9720abb Compare April 6, 2022 09:28
Signed-off-by: Quan TRAN <account@itscaro.me>
Comment on lines +7 to +9
- "image/**"
- "*image"
- "image*"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mumoshu I would like to try docker build on some branch without pushing to registry

Copy link
Contributor

@mumoshu mumoshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot of changes in a single PR but everything looks nice!
Let's go ahead and see how it works in the wild 👍

@mumoshu mumoshu merged commit f1a250c into helmfile:main Apr 8, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants