fix output-dir issue

[yxxhero]

Signed-off-by: yxxhero aiopsclub@163.com

Fixed: #30

[itscaro]

@yxxhero Could you check where the final path is constructed? with filepath.Join(), we should not have to trim slash in input?

Around here

helmfile/pkg/state/state.go

Line 1373 in f1a250c

releaseOutputDir, err := st.GenerateOutputDir(outputDir, release, opts.OutputDirTemplate)

Thank you for your contribution.

[yxxhero]

outputDirTemplate = filepath.Join("{{ .OutputDir }}", "{{ .State.BaseName }}-{{ .State.AbsPathSHA1 }}-{{ .Release.Name}}")
The code use go template. @itscaro

[itscaro]

I see, if we do slash-trimming in input, could you please trim "\" for windows too?

Or, maybe it's better to replace double os.PathSeparator here?

helmfile/pkg/state/state.go

Line 3116 in f1a250c

return buf.String(), nil

[yxxhero]

ok. got it. I forget the window platform. I will see it latter. @itscaro

[mumoshu]

LGTM. Thanks a lot for fixing it @yxxhero ☺️