Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix non-existent custom temp dir #37

Merged
merged 1 commit into from
Apr 13, 2022
Merged

Fix non-existent custom temp dir #37

merged 1 commit into from
Apr 13, 2022

Conversation

itscaro
Copy link
Contributor

@itscaro itscaro commented Apr 12, 2022 •
edited

When using non-existent custom temporary dir with HELMFILE_TEMPDIR, raised errors are not clear. I propose that we try to create automatically the custom temp dir.

HELMFILE_TEMPDIR=.helmfile

in ./helmfile.yaml: in .helmfiles[2]: in ./helmfile.yaml: 2 errors:
err 0: open .helmfile/staging-x-values-6b4cd67d8b: no such file or directory
err 1: open .helmfile/staging-x-values-5f97d6746b: no such file or directory

@itscaro
(fix) non-existent custom temp dir
12e103d 
Signed-off-by: Quan TRAN <account@itscaro.me>
@itscaro itscaro requested a review from mumoshu as a code owner April 12, 2022 20:33
mumoshu
mumoshu approved these changes Apr 13, 2022
View reviewed changes
Copy link
Contributor

@mumoshu mumoshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for your continued effort ☺️

@mumoshu mumoshu changed the title (fix) non-existent custom temp dir Fix non-existent custom temp dir Apr 13, 2022
@mumoshu mumoshu merged commit 7af57ad into helmfile:main Apr 13, 2022
@itscaro itscaro deleted the qtran/fix-temp-dir branch April 14, 2022 05:49
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mumoshu mumoshu mumoshu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@itscaro @mumoshu