Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: optimize version output #412

Merged
merged 2 commits into from Oct 8, 2022
Merged

feat: optimize version output #412

merged 2 commits into from Oct 8, 2022

Conversation

yxxhero
Copy link
Member

@yxxhero yxxhero commented Oct 5, 2022

Signed-off-by: yxxhero aiopsclub@163.com

▓▓▓ ./helmfile

  Version            0.145.4
  Git Commit         N/A
  Build Date         N/A
  Commit Date        N/A
  Dirty Build        no
  Go version         1.19
  Compiler           gc
  Platform           linux/amd64

  │ A new release is available: 0.145.4 → v0.146.0
  │ https://github.com/helmfile/helmfile/releases/tag/v0.146.0


[root@devops helmfile]# ./helmfile version -o json
{
  "buildDate": "N/A",
  "commitDate": "N/A",
  "compiler": "gc",
  "gitCommit": "N/A",
  "goVersion": "go1.19",
  "platform": "linux/amd64",
  "version": "0.145.4"
}

  │ A new release is available: 0.145.4 → v0.146.0
  │ https://github.com/helmfile/helmfile/releases/tag/v0.146.0

@yxxhero yxxhero force-pushed the version_classy_version branch 3 times, most recently from 928f6a3 to bb9ef61 Compare October 6, 2022 04:53
Copy link
Contributor

@mumoshu mumoshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall!
Can we also add a flag to disable the new version check feature for cases where helmfile is used in an isolated/restrictive environment with no internet access?

@yxxhero
Copy link
Member Author

yxxhero commented Oct 6, 2022

@mumoshu set HELMFILE_UPGRADE_NOTICE_DISABLED to any not empty value to disable upgrade notice behavior.

Signed-off-by: yxxhero <aiopsclub@163.com>
docs/index.md Outdated Show resolved Hide resolved
mumoshu
mumoshu previously approved these changes Oct 7, 2022
Copy link
Contributor

@mumoshu mumoshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you as always for your effort!

Signed-off-by: yxxhero <aiopsclub@163.com>
@yxxhero
Copy link
Member Author

yxxhero commented Oct 7, 2022

@mumoshu fix the ci error. done.

Copy link
Contributor

@mumoshu mumoshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Thanks a bunch!

@mumoshu mumoshu merged commit 8f7796b into main Oct 8, 2022
@mumoshu mumoshu deleted the version_classy_version branch October 8, 2022 05:26
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants