Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use curl instead of wget & update helm to 3.10.1 #467

Merged
merged 1 commit into from
Oct 25, 2022
Merged

use curl instead of wget & update helm to 3.10.1 #467

merged 1 commit into from
Oct 25, 2022

Conversation

itscaro
Copy link
Contributor

@itscaro itscaro commented Oct 25, 2022 •
edited

To avoid wget output / progress. and uniformise usage between curl / wget

@itscaro
use curl instead of wget & update helm to 3.10.1
7d05ffd 
Signed-off-by: Quan TRAN <itscaro@users.noreply.github.com>
yxxhero
yxxhero approved these changes Oct 25, 2022
View reviewed changes
Copy link
Member

@yxxhero yxxhero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yxxhero yxxhero merged commit 4a5928e into main Oct 25, 2022
@yxxhero yxxhero deleted the qtran/docker-build-wget branch October 25, 2022 08:17
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yxxhero yxxhero yxxhero approved these changes

@mumoshu mumoshu Awaiting requested review from mumoshu mumoshu is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@itscaro @yxxhero