Allow helmfile statefile to passed by stdin #520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@xiaomudk ci issue. |
yxxhero
reviewed
Nov 14, 2022
|
@xiaomudk add a e2e test will be better. |
|
Yeah, this is worth being covered in an E2E test! |
xiaomudk
force-pushed
the
patch-7
branch
2 times, most recently
from
a0527d3
to
cd449aa
Compare
mumoshu
reviewed
Nov 14, 2022
xiaomudk
force-pushed
the
patch-7
branch
7 times, most recently
from
c19e3f8
to
bfc1e49
Compare
yxxhero
reviewed
Nov 14, 2022
yxxhero
reviewed
Nov 14, 2022
Signed-off-by: xiaomudk <xiaomudk@gmail.com>
|
@xiaomudk I have no questions. |
|
@mumoshu ping |
mumoshu
reviewed
Nov 22, 2022
Signed-off-by: Yusuke Kuoka <ykuoka@gmail.com>
mumoshu
reviewed
Nov 22, 2022
Signed-off-by: Yusuke Kuoka <ykuoka@gmail.com>
mumoshu
reviewed
Nov 22, 2022
mumoshu
reviewed
Nov 22, 2022
Signed-off-by: Yusuke Kuoka <ykuoka@gmail.com>
Signed-off-by: Yusuke Kuoka <ykuoka@gmail.com>
mumoshu
approved these changes
Nov 22, 2022
|
@mumoshu Thank you so much, you are such a helpful person! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #505
example:
Signed-off-by: xiaomudk xiaomudk@gmail.com