Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add openssh-client to images #53

Merged
merged 2 commits into from
Apr 22, 2022
Merged

feat: Add openssh-client to images #53

merged 2 commits into from
Apr 22, 2022

Conversation

itscaro
Copy link
Contributor

@itscaro itscaro commented Apr 21, 2022 •
edited by mumoshu

I profit the PR to remove pip from debian-based images

Closes #41

@itscaro
(feat) add openssh-client to images (closes helmfile#41)
c692036 
Signed-off-by: Quan TRAN <account@itscaro.me>
@itscaro itscaro requested a review from mumoshu as a code owner April 21, 2022 20:41
@itscaro
remove pip from debian-based images
8304d49 
Signed-off-by: Quan TRAN <account@itscaro.me>
yxxhero
yxxhero approved these changes Apr 21, 2022
View reviewed changes
Copy link
Member

@yxxhero yxxhero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@mumoshu mumoshu changed the title (feat) add openssh-client to images (closes #41) feat: Add openssh-client to images Apr 22, 2022
mumoshu
mumoshu approved these changes Apr 22, 2022
View reviewed changes
Copy link
Contributor

@mumoshu mumoshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@mumoshu mumoshu merged commit e1d8cea into helmfile:main Apr 22, 2022
@itscaro itscaro deleted the qtran/ssh-client-in-image branch April 22, 2022 06:12
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mumoshu mumoshu mumoshu approved these changes

@yxxhero yxxhero yxxhero approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Embedded helmfiles accessing through ssh not working, when using helmfile dockerimage
3 participants
@itscaro @mumoshu @yxxhero