clean: optimize post-render code #577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yxxhero
force-pushed
the
add-postrender-test
branch
from
c2577c0
to
a56d1a2
Compare
Signed-off-by: yxxhero <aiopsclub@163.com>
yxxhero
force-pushed
the
add-postrender-test
branch
from
a56d1a2
to
6a640ac
Compare
xiaomudk
approved these changes
Dec 14, 2022
mumoshu
reviewed
Dec 14, 2022
| @@ -258,10 +258,6 @@ func (helm *execer) SyncRelease(context HelmContext, name, chart string, flags . | |||
| env["HELM_TILLER_HISTORY_MAX"] = strconv.Itoa(context.HistoryMax) | |||
| } | |||
|
|
|||
| if helm.IsHelm3() && helm.postRenderer != "" { | |||
There was a problem hiding this comment.
Probably we remove the postRenderer field out of the helmExec struct now as unused?
yxxhero
commented
Dec 14, 2022
| if helm.IsHelm3() { | ||
| switch { | ||
| // helm.GetPostRenderer() comes from cmd flag. | ||
| case helm.GetPostRenderer() != "": |
There was a problem hiding this comment.
@mumoshu helm.GetPostRenderer() != "" will get postRenderer of HelmExec.
There was a problem hiding this comment.
Ah gotcha! Thanks for clarifying
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clean: optimize post-render code