Reset values flag #602
Merged
Reset values flag #602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkoralsky
requested review from
mumoshu,
itscaro,
yxxhero and
xiaomudk
as code owners
|
@yxxhero would you mind to take a look at this? We talked about the problem in "discussions" week ago :) Im also open for suggestions if it can be implemented better |
|
I will review as soon as I can. |
mumoshu
force-pushed
the
reset-values-flag
branch
from
1b80041
to
2994fe1
Compare
|
@kkoralsky when has --reset-vaules and --reuse-values in same. what will happen? |
|
@kkoralsky we can follow the behavior of helm. |
yxxhero
reviewed
Jan 14, 2023
yxxhero
reviewed
Jan 14, 2023
yxxhero
reviewed
Jan 14, 2023
yxxhero
reviewed
Jan 14, 2023
kkoralsky
force-pushed
the
reset-values-flag
branch
from
2994fe1
to
17c03a9
Compare
kkoralsky
commented
Jan 14, 2023
|
@kkoralsky please fix DCO issue. |
|
@mumoshu I think it's ok. do you have some suggestions? |
|
@kkoralsky BTW. please update the docs. |
yxxhero
reviewed
Jan 14, 2023
…true Signed-off-by: Karol Ossowski <k@koralsky.pl>
Signed-off-by: Karol Ossowski <k@koralsky.pl>
Signed-off-by: Karol Ossowski <k@koralsky.pl>
Signed-off-by: Karol Ossowski <k@koralsky.pl>
…ocessing Signed-off-by: Karol Ossowski <k@koralsky.pl>
kkoralsky
force-pushed
the
reset-values-flag
branch
from
17c03a9
to
2fdb7c2
Compare
Signed-off-by: Karol Ossowski <k@koralsky.pl>
yxxhero
reviewed
Jan 16, 2023
| } | ||
|
|
||
| return flags | ||
| } |
There was a problem hiding this comment.
please add unittest for the func. @kkoralsky
|
rest of is LGTM. |
mumoshu
approved these changes
Jan 17, 2023
There was a problem hiding this comment.
LGTM. Thanks a lot for your contribution @kkoralsky and review @yxxhero
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implemented
--reset-valuesflag overriding.helmDefaults.reuseValues=trueas discussed: #593