Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove temp_rand and use k8s.io/apimachinery/pkg/util/rand #69

Merged
merged 1 commit into from
Apr 27, 2022
Merged

remove temp_rand and use k8s.io/apimachinery/pkg/util/rand #69

merged 1 commit into from
Apr 27, 2022

Conversation

yxxhero
Copy link
Member

@yxxhero yxxhero commented Apr 27, 2022

Signed-off-by: yxxhero aiopsclub@163.com

remove temp_rand and use k8s.io/apimachinery/pkg/util/rand

@yxxhero
remove temp_rand and use k8s.io/apimachinery/pkg/util/rand
218d7a6 
Signed-off-by: yxxhero <aiopsclub@163.com>
mumoshu
mumoshu approved these changes Apr 27, 2022
View reviewed changes
Copy link
Contributor

@mumoshu mumoshu left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I was reluctant to introduce the k8s.io dependency just for this function initially, but we eventually introduced the dep in another circumstance so we definitely have no need to keep the copy of the function today. Good catch!

@mumoshu mumoshu merged commit cc6edc1 into helmfile:main Apr 27, 2022
@yxxhero yxxhero deleted the remote_temp_rand branch April 28, 2022 03:58
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mumoshu mumoshu mumoshu approved these changes

@itscaro itscaro Awaiting requested review from itscaro itscaro is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yxxhero @mumoshu