Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix needs issue when release installed is false #997

Merged
merged 10 commits into from
Mar 4, 2024
Merged

fix needs issue when release installed is false #997

merged 10 commits into from
Mar 4, 2024

Conversation

yxxhero
Copy link
Member

@yxxhero yxxhero commented Sep 3, 2023

fix: #987

@yxxhero
Copy link
Member Author

yxxhero commented Sep 3, 2023

Fix needs issue when release installed is false.

It just logs currently.

@mumoshu

@yxxhero yxxhero force-pushed the fix-needs-issue-when-release-installed-is-false branch from 3758844 to 4e350fe Compare September 3, 2023 23:53
mumoshu
mumoshu reviewed Sep 4, 2023
View reviewed changes
pkg/state/state.go Outdated Show resolved Hide resolved
@yxxhero
Copy link
Member Author

yxxhero commented Sep 4, 2023 •
edited

@mumoshu WDYT about the changes? I will fix the tests if it's accepted.

mumoshu
mumoshu reviewed Sep 4, 2023
View reviewed changes
pkg/state/state.go
var needs []string
releaseInstalledInfo := make(map[string]bool)
for _, r := range st.OrginReleases {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the difference between st.Releases and st.OriginReleases?

I'd appreciate it if you could give me any pointer(file name + line number) that illustrates the biggest difference between the two.. 🙏

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

st.Releases will be part of all releases when has a --selector flag. st.OriginReleases contains all the releases. @mumoshu

@yxxhero yxxhero force-pushed the fix-needs-issue-when-release-installed-is-false branch from 7ce76f1 to 9f81895 Compare September 4, 2023 11:40
@yxxhero
Copy link
Member Author

yxxhero commented Sep 6, 2023

@mumoshu

@stale
Copy link

stale bot commented Sep 20, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Sep 20, 2023
@yxxhero
Copy link
Member Author

yxxhero commented Sep 20, 2023

ping

@stale stale bot removed the wontfix This will not be worked on label Sep 20, 2023
@stale
Copy link

stale bot commented Oct 4, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Oct 4, 2023
@yxxhero yxxhero requested review from renehernandez and a team October 5, 2023 00:39
@stale stale bot removed the wontfix This will not be worked on label Oct 5, 2023
@stale
Copy link

stale bot commented Oct 19, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Oct 19, 2023
@pathob
Copy link
Contributor

pathob commented Oct 27, 2023

Would be great to see this fixed @yxxhero @mumoshu

@yxxhero yxxhero added in progress and removed wontfix This will not be worked on labels Oct 27, 2023
@mighty1231 mighty1231 mentioned this pull request Dec 12, 2023
Merged
@yxxhero yxxhero force-pushed the fix-needs-issue-when-release-installed-is-false branch 2 times, most recently from c38fd97 to 613a31f Compare February 9, 2024 07:53
mumoshu
mumoshu reviewed Feb 9, 2024
View reviewed changes
pkg/state/state.go Outdated Show resolved Hide resolved
@yxxhero yxxhero force-pushed the fix-needs-issue-when-release-installed-is-false branch from 6f13bd5 to dd0c6d7 Compare February 9, 2024 11:27
@yxxhero
Copy link
Member Author

yxxhero commented Feb 9, 2024

@mumoshu updated.

mumoshu
mumoshu approved these changes Mar 4, 2024
View reviewed changes
Copy link
Contributor

@mumoshu mumoshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your patience and effort @yxxhero and everyone!

yxxhero and others added 10 commits March 4, 2024 10:04
@yxxhero
fix needs issue when release installed is false
b2c0f2d 
Signed-off-by: yxxhero <aiopsclub@163.com>
@yxxhero
fix issue
ddba849 
Signed-off-by: yxxhero <aiopsclub@163.com>
@yxxhero
fix issue
e0316c3 
Signed-off-by: yxxhero <aiopsclub@163.com>
@yxxhero
update tests
c29cfdf 
Signed-off-by: yxxhero <aiopsclub@163.com>
@yxxhero
fix tests
417928d 
Signed-off-by: yxxhero <aiopsclub@163.com>
@yxxhero
rename ReFormatNeeds to reformatNeeds
56168ef 
Signed-off-by: yxxhero <aiopsclub@163.com>
@yxxhero
fix tests
a8b6f36 
Signed-off-by: yxxhero <aiopsclub@163.com>
@yxxhero
fix tests
2554c90 
Signed-off-by: yxxhero <aiopsclub@163.com>
@yxxhero @mumoshu
Update pkg/state/state.go
978a6d2 
Co-authored-by: Yusuke Kuoka <ykuoka@gmail.com>
Signed-off-by: yxxhero <aiopsclub@163.com>
@yxxhero
fix tests
43fcbe1 
Signed-off-by: yxxhero <aiopsclub@163.com>
@yxxhero yxxhero force-pushed the fix-needs-issue-when-release-installed-is-false branch from 68458e7 to 43fcbe1 Compare March 4, 2024 02:04
@yxxhero yxxhero merged commit 5904864 into main Mar 4, 2024
14 checks passed
@yxxhero yxxhero deleted the fix-needs-issue-when-release-installed-is-false branch March 4, 2024 02:30
@yxxhero
Copy link
Member Author

yxxhero commented Mar 4, 2024

@pathob merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mumoshu mumoshu mumoshu approved these changes

@itscaro itscaro Awaiting requested review from itscaro itscaro is a code owner

@xiaomudk xiaomudk Awaiting requested review from xiaomudk xiaomudk is a code owner

@renehernandez renehernandez Awaiting requested review from renehernandez

Assignees
No one assigned
Labels
in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

helmfile sync ignores needs when needed chart is not installed
3 participants
@yxxhero @pathob @mumoshu