Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for assuming AWS IAM roles without AWS profiles #151

Merged
merged 1 commit into from Jun 21, 2023

Conversation

mumoshu
Copy link
Collaborator

@mumoshu mumoshu commented Jun 20, 2023

This adds the support for assuming AWS IAM roles via vals ref URLs.

This is an important usability enhancement because we currently support assuming roles only by configuring AWS profiles before calling vals (and helmfile, which is a tool that integrates vals as a library).

In other words, you no longer need to configure AWS profiles to let vals assume role before reading e.g. AWS SSM Parameter Store. Instead, you just give a role_arn parameter in the vals ref URL query and vals assumes role for you.

@yxxhero
Copy link
Member

yxxhero commented Jun 20, 2023

@mumoshu please fix DCO issue.

This adds the support for assuming AWS IAM roles via vals ref URLs.
This is an important usability enhancement because we currently support assuming roles only by configuring AWS profiles before calling vals (and helmfile, which is a tool that integrates vals as a library).
In other words, you no longer need to configure AWS profiles to let vals assume role before reading e.g. AWS SSM Parameter Store.
Instead, you just give a `role_arn` parameter in the vals ref URL query and vals assumes role for you.

Signed-off-by: Yusuke Kuoka <ykuoka@gmail.com>
Copy link
Member

@yxxhero yxxhero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yxxhero yxxhero merged commit d9739f1 into main Jun 21, 2023
3 checks passed
@yxxhero yxxhero deleted the assume-role-support branch June 21, 2023 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants