Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mount point option to vault provider #42

Merged

Conversation

tottoto
Copy link
Contributor

@tottoto tottoto commented Jan 14, 2021

  • Support VAULT_LOGIN_MOUNT_POINT to specify mount point when the auth method is approle
  • The default behaviour is not changed(the default value is set to /approle)

Copy link
Collaborator

@mumoshu mumoshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your contribution @tottoto ☺️

@mumoshu mumoshu merged commit 8e55817 into helmfile:master Jan 30, 2021
@tottoto
Copy link
Contributor Author

tottoto commented Feb 1, 2021

@mumoshu Thank you! Could you release new version please?

@mumoshu
Copy link
Collaborator

mumoshu commented Feb 2, 2021

@tottoto Thanks for the reminder! 0.13.0 has been released for this.

mumoshu added a commit to roboll/helmfile that referenced this pull request Feb 2, 2021
@tottoto
Copy link
Contributor Author

tottoto commented Feb 2, 2021

Thank you!!

mumoshu added a commit to roboll/helmfile that referenced this pull request Feb 3, 2021
@tottoto tottoto deleted the add_mount_point_option_to_vault_provider branch October 11, 2022 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants