Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement type casts #10

Closed
rainman110 opened this issue Jul 16, 2018 · 1 comment
Closed

Implement type casts #10

rainman110 opened this issue Jul 16, 2018 · 1 comment
Assignees
@Markus-Goetz
Labels
type system
Projects
ASSET Support
Milestone
Foundation

Comments

@rainman110
Copy link
Member

rainman110 commented Jul 16, 2018 •
edited

We need to support function astype

Required at
@rainman110 rainman110 created this issue from a note in ASSET Support (To do) Jul 16, 2018
@bhagemeier bhagemeier added this to the Type System Support milestone Jul 16, 2018
@Markus-Goetz Markus-Goetz self-assigned this Jul 31, 2018
Markus-Goetz added a commit that referenced this issue Jul 31, 2018
@Markus-Goetz
Realized HeAT's type system. Enabled type casting. Major refactoring …
f347f4d 
…of existing code to utilize new type system.

Resolves issues #10 and #12

Detailed overview of the changes:

* setup.py requires torch and numpy, h5py is optional dependency
* added io module
    - contains optional hdf5 loading function
    - enhanced hdf5 loading function to support arbitrary dimensions
    - added documentation
    - added tests
* added random module
    - copy over of the existing global seed initialization and uniform sampling
    - test cases and documentation missing
* enhanced communicator module
    - introduced abstract Communicator base class
    - communicators must now always be instantiated for a tensor
    - each communicator now has a chunk method, i.e. dividing a shape into slices according to the communication strategy and split axis, previously part of the load_h5 method
    - added tests
    - added documentation
* removed float16/half type, only rudimentary CPU support from PyTorch
* core module pulls io unqualified, random qualified, tensor qualified through to the parent module
* enhanced tensor module
    - introduced new constructor method
    - refactored existing code to utilize existing constructor
    - added a number of TODOs for missing documentation, tests, functionality, ...
    - added tested and documented astype cast function (see issue #10)
* refactored kmeans code
    - now utilizes the refactored random and tensor modules
    - refactored tests cases to utilize Python's unittest, need to be enhanced to better check KMeans functionality
    - added TODOs for missing documentation and functionality
This was referenced Jul 31, 2018
Closed
Merged
@rainman110
Copy link
Member Author

Closed by #42

@rainman110 rainman110 moved this from To do to Done in ASSET Support Aug 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Markus-Goetz Markus-Goetz

Labels
type system
Projects
ASSET Support
  
Done
Milestone
Foundation
Development

No branches or pull requests
3 participants
@Markus-Goetz @bhagemeier @rainman110