Fix #1085: Convolve with distributed kernel on multiple GPUs

[shahpratham]

Description

Issue resolved: #1085
Convolve is not working with multiple gpus with distributed kernel.

Changes proposed:

• bcast --> Bcast

Type of change

• Bug fix

Due Diligence

• All split configurations tested
• Multiple dtypes tested in relevant functions
• Documentation updated (if needed)
• Title of PR is suitable for corresponding CHANGELOG entry

Does this change modify the behaviour of other functions? If so, which?

no

[ghost]

👇 Click on the image for a new way to code review

Legend

[mtar]

Hi @shahpratham , more changes are necessary. Bcast uses the buffer for input and output.

[mtar]

I need the bug fix now. So, I'm going to fix the PR.

[codecov]

Codecov Report

Merging #1095 (10437b1) into main (576eb78) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1095   +/-   ##
=======================================
  Coverage   91.80%   91.80%           
=======================================
  Files          72       72           
  Lines       10519    10520    +1     
=======================================
+ Hits         9657     9658    +1     
  Misses        862      862           

Flag	Coverage Δ
unit	91.80% <100.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
heat/core/signal.py	97.80% <100.00%> (+0.02%)	⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[ClaudiaComito]

I need the bug fix now. So, I'm going to fix the PR.

Thanks @mtar. Generally speaking, if you've identified problem and solution, feel free to submit a fix right away.
In this specific case, the error arises on the cluster in multi-GPU set up, so I'm not sure that @shahpratham could have done any more debugging.

I'll go back to PR reviews on March 3rd.