Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Distributed Fast Fourier Transforms" #1284

Conversation

ClaudiaComito
Copy link
Contributor

Reverts #1218

I propose to revert the latest merge to help debug the CI matrix that has been failing since yesterday.

@ghost
Copy link

ghost commented Nov 28, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

Copy link
Contributor

Thank you for the PR!

Copy link

codecov bot commented Nov 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8b87890) 91.82% compared to head (2e91d87) 91.83%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1284      +/-   ##
==========================================
+ Coverage   91.82%   91.83%   +0.01%     
==========================================
  Files          79       77       -2     
  Lines       11457    11193     -264     
==========================================
- Hits        10520    10279     -241     
+ Misses        937      914      -23     
Flag Coverage Δ
unit 91.83% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mtar
Copy link
Collaborator

mtar commented Nov 28, 2023

Apparently the latest merge doesn't cause the failing runs.

@ClaudiaComito
Copy link
Contributor Author

Apparently the latest merge doesn't cause the failing runs.

Thanks @mtar , I will close the PR then.

@mtar mtar deleted the revert-1218-features/1097-Provide_Fast_Fourier_Transform_FFT branch February 28, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants