Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add decomposition module and PCA-interface #1502

Merged
merged 31 commits into from
Jul 11, 2024
Merged

Add decomposition module and PCA-interface #1502

merged 31 commits into from
Jul 11, 2024

Conversation

mrfh92
Copy link
Collaborator

@mrfh92 mrfh92 commented May 31, 2024 •
edited
Loading

see #1455

Due Diligence

  • General:
  • Implementation:
    • unit tests: all split configurations tested
    • unit tests: multiple dtypes tested
    • documentation updated where needed

Description

Issue/s resolved: #

Changes proposed:

Type of change

Memory requirements

Performance

Does this change modify the behaviour of other functions? If so, which?

yes / no

@mrfh92 mrfh92 added high-level functions High-level machine-learning algorithms linalg ESAPCA relevant for the ESA-funded project "ESAPCA" labels May 31, 2024
@mrfh92 mrfh92 self-assigned this May 31, 2024
@mrfh92 mrfh92 added enhancement New feature or request and removed linalg labels May 31, 2024
@mrfh92 mrfh92 changed the title Add PCA-interface Add decomposition module and PCA-interface May 31, 2024
@mrfh92 mrfh92 mentioned this pull request May 31, 2024
Closed
@github-actions GitHub Actions
Copy link
Contributor

Thank you for the PR!

@github-actions GitHub Actions
Copy link
Contributor

Thank you for the PR!

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

Thank you for the PR!

@codecov Codecov
Copy link

codecov bot commented May 31, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.00%. Comparing base (1663a53) to head (7259c6a).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1502      +/-   ##
==========================================
+ Coverage   91.91%   92.00%   +0.08%     
==========================================
  Files          81       83       +2     
  Lines       11977    12072      +95     
==========================================
+ Hits        11009    11107      +98     
+ Misses        968      965       -3
Flag Coverage Δ
unit 92.00% <100.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Hoppe added 3 commits June 3, 2024 14:43
continued working on PCA interface; finished first draft (so far with…
c0338be 
…out tests)
Merge branch 'features/1455-Add_decomposition-module_and_PCA-interfac…
de04301 
…e' of github.com:helmholtz-analytics/heat into features/1455-Add_decomposition-module_and_PCA-interface
...
e5df48c
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 3, 2024

Thank you for the PR!

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 3, 2024

Thank you for the PR!

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 6, 2024

Thank you for the PR!

mrfh92 and others added 4 commits June 6, 2024 23:09
@mrfh92
Merge pull request #1513 from helmholtz-analytics/features/1455-Add_d…
a61a549 
…ecomposition-module_and_PCA-interface

Add TS-SVD and PCA-interface to ESAPCA-branch
Merge branch 'features/1456-Add_tall-skinny_SVD' into features/1455-A…
cc1e7db 
…dd_decomposition-module_and_PCA-interface
removed in-place option as it would not work reasonable for now; incr…
8b80079 
…eased test coverage
removed a print
3e9b058
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 7, 2024

Thank you for the PR!

@mrfh92
Merge pull request #1517 from helmholtz-analytics/features/1455-Add_d…
8edaffc 
…ecomposition-module_and_PCA-interface

Features/1455 add decomposition module and pca interface
@mrfh92 mrfh92 added the PR talk label Jul 1, 2024
@ClaudiaComito ClaudiaComito added this to the 1.5.0 milestone Jul 1, 2024
@mrfh92 mrfh92 removed the PR talk label Jul 1, 2024
@mrfh92 mrfh92 requested a review from mtar July 3, 2024 13:17
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 5, 2024

Thank you for the PR!

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 8, 2024

Thank you for the PR!

mtar
mtar requested changes Jul 9, 2024
View reviewed changes
heat/decomposition/pca.py Outdated Show resolved Hide resolved
heat/decomposition/pca.py Outdated Show resolved Hide resolved
heat/decomposition/pca.py Outdated Show resolved Hide resolved
heat/decomposition/pca.py Outdated Show resolved Hide resolved
heat/decomposition/pca.py Outdated Show resolved Hide resolved
heat/decomposition/pca.py Outdated Show resolved Hide resolved
heat/decomposition/pca.py Outdated Show resolved Hide resolved
heat/decomposition/pca.py Outdated Show resolved Hide resolved
mrfh92 and others added 5 commits July 10, 2024 12:45
@mrfh92 @mtar
Update heat/decomposition/pca.py
f4a2227 
Co-authored-by: Michael Tarnawa <m.tarnawa@fz-juelich.de>
@mrfh92 @mtar
Update heat/decomposition/pca.py
c81f2ed 
Co-authored-by: Michael Tarnawa <m.tarnawa@fz-juelich.de>
@mrfh92 @mtar
Update heat/decomposition/pca.py
733f3d7 
Co-authored-by: Michael Tarnawa <m.tarnawa@fz-juelich.de>
@mrfh92 @mtar
Update heat/decomposition/pca.py
564f1d3 
Co-authored-by: Michael Tarnawa <m.tarnawa@fz-juelich.de>
@mrfh92
Merge branch 'main' into features/1455-Add_decomposition-module_and_P…
29a45f1 
…CA-interface
@github-actions GitHub Actions
Copy link
Contributor

Thank you for the PR!

2 similar comments
@github-actions GitHub Actions
Copy link
Contributor

Thank you for the PR!

@github-actions GitHub Actions
Copy link
Contributor

Thank you for the PR!

@github-actions GitHub Actions
Copy link
Contributor

Thank you for the PR!

@mrfh92
Copy link
Collaborator Author

mrfh92 commented Jul 11, 2024

@mtar @ClaudiaComito thx for reviewing. I have incorporated your suggestions.

@mrfh92 mrfh92 requested a review from mtar July 11, 2024 09:00
@mtar
Copy link
Collaborator

mtar commented Jul 11, 2024

@mrfh92 One single line is is missing coverage.

@mrfh92
Copy link
Collaborator Author

mrfh92 commented Jul 11, 2024

@mtar now it should be covered

@github-actions GitHub Actions
Copy link
Contributor

Thank you for the PR!

mtar
mtar approved these changes Jul 11, 2024
View reviewed changes
Copy link
Collaborator

@mtar mtar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@mrfh92 mrfh92 merged commit 2c15d43 into main Jul 11, 2024
53 checks passed
@mrfh92
Copy link
Collaborator Author

mrfh92 commented Jul 11, 2024

@mtar @ClaudiaComito thx for reviewing 👍
(btw: this is milestone 2.1 of ESAPCA)

@mrfh92 mrfh92 deleted the features/1455-Add_decomposition-module_and_PCA-interface branch July 11, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtar mtar mtar approved these changes

@ClaudiaComito ClaudiaComito Awaiting requested review from ClaudiaComito

Assignees

@mrfh92 mrfh92

Labels
enhancement New feature or request ESAPCA relevant for the ESA-funded project "ESAPCA" high-level functions High-level machine-learning algorithms
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mrfh92 @mtar @ClaudiaComito