Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features/292 lasso regression example #307

Merged
merged 13 commits into from Jul 10, 2019

Conversation

krajsek
Copy link
Member

@krajsek krajsek commented Jun 12, 2019

Add a lasso regression example illustrating the usage of the library. The lasso regression example uses coordinate descent with soft-thresholding. Besides the HeAT version, also Numpy and PyTorch examples are provided in order to show the similarity in their implementations.

@codecov-io
Copy link

codecov-io commented Jun 12, 2019

Codecov Report

Merging #307 into master will decrease coverage by 0.08%.
The diff coverage is 94.07%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #307      +/-   ##
==========================================
- Coverage   96.87%   96.78%   -0.09%     
==========================================
  Files          49       53       +4     
  Lines        7875     8128     +253     
==========================================
+ Hits         7629     7867     +238     
- Misses        246      261      +15
Impacted Files Coverage Δ
heat/ml/regression/__init__.py 100% <100%> (ø)
heat/ml/__init__.py 100% <100%> (ø) ⬆️
heat/core/dndarray.py 94.97% <100%> (+0.02%) ⬆️
heat/core/tests/test_dndarray.py 100% <100%> (ø) ⬆️
heat/ml/regression/lasso/tests/test_lasso.py 100% <100%> (ø)
heat/ml/regression/lasso/__init__.py 100% <100%> (ø)
heat/ml/regression/lasso/lasso.py 90.38% <90.38%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e324b2...5a1a4bc. Read the comment docs.

Copy link
Member

@coquelin77 coquelin77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this all looks good to me. but can you make the example script so someone can run it from the base directory? (as discussed previously

@krajsek krajsek merged commit 98d89ea into master Jul 10, 2019
@Markus-Goetz Markus-Goetz deleted the features/292-lasso-regression-example branch January 31, 2020 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants