Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eye checks if either position is above the lshape of the tensor, if s… #534

Merged
merged 8 commits into from Apr 7, 2020

Conversation

coquelin77
Copy link
Member

Description

ht.eye now will not throw an error for split=1 with gshape[0] < gshape[1]. e.g it supports uneven matrices.

Issue/s resolved: #528

Changes proposed:

  • added if condition in the setting of values in eye()

Type of change

Remove irrelevant options:

  • Bug fix (non-breaking change which fixes an issue)
  • Documentation update

Due Diligence

  • All split configurations tested
  • Multiple dtypes tested in relevant functions
  • Documentation updated (if needed)
  • Updated changelog.md under the title "Pending Additions"

Does this change modify the behaviour of other functions? If so, which?

no

@coquelin77 coquelin77 requested a review from Cdebus April 7, 2020 10:06
@codecov
Copy link

codecov bot commented Apr 7, 2020

Codecov Report

Merging #534 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #534   +/-   ##
=======================================
  Coverage   96.28%   96.28%           
=======================================
  Files          75       75           
  Lines       14533    14541    +8     
=======================================
+ Hits        13993    14001    +8     
  Misses        540      540           
Impacted Files Coverage Δ
heat/core/factories.py 100.00% <100.00%> (ø)
heat/core/tests/test_factories.py 99.21% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a2baf3...f071388. Read the comment docs.

Markus-Goetz
Markus-Goetz previously approved these changes Apr 7, 2020
heat/core/factories.py Outdated Show resolved Hide resolved
Markus-Goetz
Markus-Goetz previously approved these changes Apr 7, 2020
@Markus-Goetz Markus-Goetz merged commit a9d61a5 into master Apr 7, 2020
@Markus-Goetz Markus-Goetz deleted the bug/528-eye-diff-dims branch April 7, 2020 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ht.eye fails for distributed non-squared tensors
2 participants