Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting rid of docs folder #536

Merged
merged 2 commits into from Apr 7, 2020
Merged

Getting rid of docs folder #536

merged 2 commits into from Apr 7, 2020

Conversation

Markus-Goetz
Copy link
Member

Description

Gets rid of the docs folder. PR template now in .github folder

Issue/s resolved: #532

Changes proposed:

  • Removing docs folder
  • PR template now in .github folder

Type of change

Remove irrelevant options:

  • Documentation update

Due Diligence

  • All split configurations tested
  • Multiple dtypes tested in relevant functions
  • Documentation updated (if needed)
  • Updated changelog.md under the title "Pending Additions"

Does this change modify the behaviour of other functions? If so, which?

no

@codecov
Copy link

codecov bot commented Apr 7, 2020

Codecov Report

Merging #536 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #536   +/-   ##
=======================================
  Coverage   96.28%   96.28%           
=======================================
  Files          75       75           
  Lines       14541    14541           
=======================================
  Hits        14001    14001           
  Misses        540      540           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9d61a5...ccebcc8. Read the comment docs.

Copy link
Member

@bhagemeier bhagemeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's an even better solutiuon than what we had in mind earlier. Doesn't require any changes to the workflow of generating documentation automatically.

@bhagemeier bhagemeier merged commit aafa242 into master Apr 7, 2020
@Markus-Goetz Markus-Goetz deleted the fixes/532-docs-folder branch April 30, 2020 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get rid of either the doc or docs folder
2 participants