Features/481 halos #541
Merged
Features/481 halos #541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #541 +/- ##
==========================================
+ Coverage 96.42% 96.43% +0.01%
==========================================
Files 75 75
Lines 14979 15092 +113
==========================================
+ Hits 14443 14554 +111
- Misses 536 538 +2
Continue to review full report at Codecov.
|
Markus-Goetz
requested changes
Apr 21, 2020
heat/core/dndarray.py
Outdated
| self.__halo_prev = res_next | ||
| self.__ishalo = True | ||
|
|
||
| def cathalo(self): |
There was a problem hiding this comment.
I do not see a reason not to allow users to concat halos for their applications. But we can make it also private I you think this is more reasonable
There was a problem hiding this comment.
okay here I am definitely going with a private method. A user should not be able to do this on his/her own.
…lytics/heat into features/481-halos
…lytics/heat into features/481-halos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements a basic halo scheme needed for inter rank operations like convolution.
The halos are concatenated to the array by request. Further features will be implemented by Luca.
Issue/s resolved: #481
Due Diligence
Does this change modify the behaviour of other functions? If so, which?
no