Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features rot90 #583

Merged
merged 21 commits into from Jul 1, 2020
Merged

Features rot90 #583

merged 21 commits into from Jul 1, 2020

Conversation

mtar
Copy link
Collaborator

@mtar mtar commented Jun 5, 2020

Description

Issue/s resolved: #555

Introduces rot90. Rotate an array on a specified plane. May change the split axis if it is in the rotation plane similar to transpose.

Changes proposed:

  • add rot90()

Type of change

New feature

Due Diligence

  • All split configurations tested
  • Multiple dtypes tested in relevant functions
  • Documentation updated (if needed)
  • Updated changelog.md under the title "Pending Additions"

Does this change modify the behaviour of other functions? If so, which?

no

@codecov
Copy link

codecov bot commented Jun 5, 2020

Codecov Report

Merging #583 into master will decrease coverage by 0.00%.
The diff coverage is 96.92%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #583      +/-   ##
==========================================
- Coverage   97.46%   97.46%   -0.01%     
==========================================
  Files          77       77              
  Lines       15396    15461      +65     
==========================================
+ Hits        15006    15069      +63     
- Misses        390      392       +2     
Impacted Files Coverage Δ
heat/core/manipulations.py 99.17% <92.59%> (-0.26%) ⬇️
heat/core/tests/test_manipulations.py 99.90% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b47f003...488a03e. Read the comment docs.

heat/core/manipulations.py Outdated Show resolved Hide resolved
heat/core/manipulations.py Show resolved Hide resolved
heat/core/manipulations.py Show resolved Hide resolved
heat/core/manipulations.py Show resolved Hide resolved
heat/core/manipulations.py Show resolved Hide resolved
heat/core/manipulations.py Outdated Show resolved Hide resolved
heat/core/manipulations.py Show resolved Hide resolved
@ClaudiaComito ClaudiaComito added this to the 2-week sprint milestone Jul 1, 2020
@Markus-Goetz
Copy link
Member

Bump, master needs merge

@Markus-Goetz Markus-Goetz merged commit bb0010b into master Jul 1, 2020
@Markus-Goetz Markus-Goetz deleted the features/555-rot90 branch July 1, 2020 15:29
@ClaudiaComito ClaudiaComito added this to Done in Current sprint Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Implement rot90()
3 participants