Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features/30 convolve #595

Merged
merged 68 commits into from
Apr 22, 2022
Merged

Features/30 convolve #595

merged 68 commits into from
Apr 22, 2022

Conversation

lucaspataro
Copy link
Contributor

@lucaspataro lucaspataro commented Jun 15, 2020

Description

This pull request implements a 1D convolution.

Issue/s resolved: #30

Changes proposed:

  • Implement 1D convolution

Type of change

  • New feature (non-breaking change which adds functionality)

Due Diligence

  • All split configurations tested
  • Multiple dtypes tested in relevant functions
  • Documentation updated (if needed)
  • Updated changelog.md under the title "Pending Additions"

Does this change modify the behaviour of other functions? If so, which?

no

@codecov
Copy link

codecov bot commented Jun 15, 2020

Codecov Report

Merging #595 (8361b36) into main (febe4fa) will increase coverage by 0.03%.
The diff coverage is 98.79%.

@@            Coverage Diff             @@
##             main     #595      +/-   ##
==========================================
+ Coverage   95.36%   95.39%   +0.03%     
==========================================
  Files          64       65       +1     
  Lines        9898     9965      +67     
==========================================
+ Hits         9439     9506      +67     
  Misses        459      459              
Flag Coverage Δ
gpu 94.63% <98.79%> (+0.03%) ⬆️
unit 91.01% <95.18%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
heat/core/dndarray.py 96.91% <94.73%> (+0.01%) ⬆️
heat/core/__init__.py 100.00% <100.00%> (ø)
heat/core/manipulations.py 98.63% <100.00%> (+<0.01%) ⬆️
heat/core/signal.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update febe4fa...8361b36. Read the comment docs.

@lucaspataro
Copy link
Contributor Author

@krajsek @Markus-Goetz @rainman110

I build upon @krajsek first implementation for the 1D convolution and added more use-cases (e.g. even kernel sizes)

Before i continue with the 2D convolution i would appreciate some feedback / tipps on my implementation.

@coquelin77
Copy link
Member

If you do this the precommit wont fail:

The extra dev dependency pulls in additional tools to support the enforcement of coding conventions (Black) and to support a pre-commit hook to do the same. In order to fully use this framework, please also install the pre-commit hook with

$ pre-commit install

In order to check compliance of your changes before even trying to commit anything, you can run

$ pre-commit run --all-files

@ClaudiaComito
Copy link
Contributor

ClaudiaComito commented Apr 20, 2022

@mtar I've expanded the tests. Not sure why codecov/patch complains about lines 66-69 and 71-74 in signal.py, they are covered and the tests run through.

@ClaudiaComito
Copy link
Contributor

@mtar I've expanded the tests. Not sure why codecov/patch complains about lines 66-69 and 71-74 in signal.py, they are covered and the tests run through.

Alright, I found and solved the problem, coverage is good now.

heat/core/signal.py Outdated Show resolved Hide resolved
@ClaudiaComito ClaudiaComito merged commit aaafea0 into main Apr 22, 2022
@ClaudiaComito ClaudiaComito deleted the features/30-convolve branch April 22, 2022 15:30
@mtar mtar removed the PR talk label Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement convolve()
6 participants