Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added aliases for arc___ functions #629

Merged
merged 3 commits into from Jul 10, 2020
Merged

Conversation

coquelin77
Copy link
Member

Description

aliases added, tests rearranged into alphabetic order in test_trigonmetrics

Issue/s resolved: #628

Changes proposed:

  • added aliases for arctan -> atan, arctan2 -> atan2, arccos -> acos, arcsin -> asin
  • ordered tests in test_trig...

Type of change

  • New feature (non-breaking change which adds functionality)

Due Diligence

  • All split configurations tested
  • Multiple dtypes tested in relevant functions
  • Documentation updated (if needed)
  • Updated changelog.md under the title "Pending Additions"

Does this change modify the behaviour of other functions? If so, which?

no

@codecov
Copy link

codecov bot commented Jul 10, 2020

Codecov Report

Merging #629 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #629   +/-   ##
=======================================
  Coverage   97.49%   97.49%           
=======================================
  Files          77       77           
  Lines       15869    15877    +8     
=======================================
+ Hits        15472    15480    +8     
  Misses        397      397           
Impacted Files Coverage Δ
heat/core/tests/test_trigonometrics.py 100.00% <100.00%> (ø)
heat/core/trigonometrics.py 96.15% <100.00%> (+0.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c17b405...6a3469a. Read the comment docs.

@Markus-Goetz Markus-Goetz merged commit d116dc3 into master Jul 10, 2020
@Markus-Goetz Markus-Goetz deleted the features/628-trig-aliases branch July 10, 2020 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature trig function aliases
2 participants