Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced NotImplemented with NotImplementedError #651

Merged
merged 4 commits into from Aug 14, 2020

Conversation

Inzlinger
Copy link
Collaborator

@Inzlinger Inzlinger commented Aug 6, 2020

Description

Replaced return NotImplemented with raise NotImplementedError

Issue/s resolved: #650

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Due Diligence

  • All split configurations tested
  • Multiple dtypes tested in relevant functions
  • Documentation updated (if needed)
  • Updated changelog.md under the title "Pending Additions"

Does this change modify the behaviour of other functions? If so, which?

no

@mtar
Copy link
Collaborator

mtar commented Aug 6, 2020

Can one of the admins verify this patch?

Inzlinger and others added 2 commits August 6, 2020 14:36
extended changelog entry
coquelin77
coquelin77 previously approved these changes Aug 10, 2020
@coquelin77
Copy link
Member

crashing due to torch 1.6.0 updates, patch being implemented currently. there is nothing here which should change with the tests. Once the patch is up, then this will be merged

@codecov
Copy link

codecov bot commented Aug 14, 2020

Codecov Report

Merging #651 into master will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #651   +/-   ##
=======================================
  Coverage   97.37%   97.37%           
=======================================
  Files          85       85           
  Lines       16646    16646           
=======================================
  Hits        16209    16209           
  Misses        437      437           
Impacted Files Coverage Δ
heat/core/communication.py 89.88% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75014ca...de1e248. Read the comment docs.

@coquelin77 coquelin77 merged commit 82c0df5 into master Aug 14, 2020
@coquelin77 coquelin77 deleted the bug/650-NotImplementedError branch August 14, 2020 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong use of NotImplemented in Communication
3 participants