Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not modify key in place within setitem, getitem #706

Merged
merged 2 commits into from Dec 11, 2020

Conversation

ClaudiaComito
Copy link
Contributor

Description

Issue/s resolved: #705

Changes proposed:

  • both __getitem__ and __setitem__ work on copy of key if possible (i.e. if key is not a tuple)

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Due Diligence

  • All split configurations tested
  • Multiple dtypes tested in relevant functions
  • Documentation updated (if needed)
  • Updated changelog.md under the title "Pending Additions"

Does this change modify the behaviour of other functions? If so, which?

no

@codecov
Copy link

codecov bot commented Dec 11, 2020

Codecov Report

Merging #706 (d277e7b) into release/0.5.x (21590bd) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff               @@
##           release/0.5.x     #706   +/-   ##
==============================================
  Coverage          97.43%   97.43%           
==============================================
  Files                 87       87           
  Lines              17110    17112    +2     
==============================================
+ Hits               16671    16673    +2     
  Misses               439      439           
Impacted Files Coverage Δ
heat/core/dndarray.py 96.44% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21590bd...d277e7b. Read the comment docs.

@ClaudiaComito ClaudiaComito added this to In progress in v0.6.0 via automation Dec 11, 2020
v0.6.0 automation moved this from In progress to Reviewer approved Dec 11, 2020
@coquelin77 coquelin77 merged commit 271162b into release/0.5.x Dec 11, 2020
v0.6.0 automation moved this from Reviewer approved to Done Dec 11, 2020
@coquelin77 coquelin77 deleted the bug/705-setitem-key-op branch December 11, 2020 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
v0.6.0
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants