Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

asarray() implementation #707

Merged
merged 6 commits into from Jan 11, 2021
Merged

asarray() implementation #707

merged 6 commits into from Jan 11, 2021

Conversation

mtar
Copy link
Collaborator

@mtar mtar commented Dec 14, 2020

Description

Issue/s resolved: #691
ht.asarray() function added. It is a shortcut for array() with copy set to False.
Some lines in array() are added such that the input array will be directly returned if there is no change. Also, the underlying data of numpy arrays / torch tensors will be reused if copy is False.

Changes proposed:

  • asarray()
  • Modification of array() functionality when copy is false

Type of change

  • New feature

Due Diligence

  • All split configurations tested
  • Multiple dtypes tested in relevant functions
  • Documentation updated (if needed)
  • Updated changelog.md under the title "Pending Additions"

Does this change modify the behaviour of other functions? If so, which?

array()

@codecov
Copy link

codecov bot commented Dec 14, 2020

Codecov Report

Merging #707 (a476789) into master (ad145c8) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #707   +/-   ##
=======================================
  Coverage   97.41%   97.41%           
=======================================
  Files          87       87           
  Lines       18333    18360   +27     
=======================================
+ Hits        17859    17886   +27     
  Misses        474      474           
Impacted Files Coverage Δ
heat/core/factories.py 99.13% <100.00%> (+0.02%) ⬆️
heat/core/tests/test_factories.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad145c8...a476789. Read the comment docs.

@mtar mtar marked this pull request as ready for review December 15, 2020 10:28
@coquelin77 coquelin77 merged commit 9638e38 into master Jan 11, 2021
@coquelin77 coquelin77 deleted the feature/691-asarray branch January 11, 2021 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

implement asarray
2 participants