Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix finding spectral gap with identical diffs #716

Merged
merged 6 commits into from Mar 11, 2021

Conversation

sebimarkgraf
Copy link
Contributor

@sebimarkgraf sebimarkgraf commented Jan 21, 2021

Issue/s resolved: #715

Changes proposed:

  • Change to argmax to prevent multiple identical diffs crashing the algorithm

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Due Diligence

  • All split configurations tested (tested in test_spectral already)
  • Multiple dtypes tested in relevant functions (tested in test_spectral already)
  • Updated changelog.md under the title "Pending Additions"

Does this change modify the behaviour of other functions? If so, which?

no

@mtar
Copy link
Collaborator

mtar commented Jan 21, 2021

GPU cluster tests are currently disabled on this Pull Request.

2 similar comments
@mtar
Copy link
Collaborator

mtar commented Jan 21, 2021

GPU cluster tests are currently disabled on this Pull Request.

@mtar
Copy link
Collaborator

mtar commented Jan 21, 2021

GPU cluster tests are currently disabled on this Pull Request.

@codecov
Copy link

codecov bot commented Feb 11, 2021

Codecov Report

Merging #716 (68999bb) into master (34c356b) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #716   +/-   ##
=======================================
  Coverage   95.97%   95.97%           
=======================================
  Files          63       63           
  Lines        8056     8056           
=======================================
  Hits         7732     7732           
  Misses        324      324           
Flag Coverage Δ
gpu 95.08% <100.00%> (+0.16%) ⬆️
unit 94.18% <100.00%> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
heat/cluster/spectral.py 93.44% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34c356b...68999bb. Read the comment docs.

coquelin77
coquelin77 previously approved these changes Mar 11, 2021
@coquelin77
Copy link
Member

run tests

@mtar
Copy link
Collaborator

mtar commented Mar 11, 2021

test this once

@coquelin77 coquelin77 merged commit ebaf73c into helmholtz-analytics:master Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spectral Clustering estimation by spectral gap breaking when multiple identical gaps exist
3 participants