Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement/721 warnings #725

Merged
merged 16 commits into from Mar 16, 2021
Merged

Enhancement/721 warnings #725

merged 16 commits into from Mar 16, 2021

Conversation

mtar
Copy link
Collaborator

@mtar mtar commented Feb 15, 2021

Description

Reduces the number of expected warnings on unit tests for all process numbers.

Issue/s resolved: #721

Changes proposed:

  • assertWarns on tests with expected warnings happening process numbers.
  • use updated numpy type names

Type of change

Bug-fix

Due Diligence

  • All split configurations tested
  • Multiple dtypes tested in relevant functions
  • Documentation updated (if needed)
  • Updated changelog.md under the title "Pending Additions"

Does this change modify the behaviour of other functions? If so, which?

no

@codecov
Copy link

codecov bot commented Feb 15, 2021

Codecov Report

Merging #725 (f298dda) into master (13627f3) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #725   +/-   ##
=======================================
  Coverage   95.82%   95.82%           
=======================================
  Files          63       63           
  Lines        8069     8069           
=======================================
  Hits         7732     7732           
  Misses        337      337           
Flag Coverage Δ
gpu 94.93% <100.00%> (ø)
unit 94.19% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
heat/core/types.py 96.35% <ø> (ø)
heat/core/statistics.py 98.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13627f3...f298dda. Read the comment docs.

@mtar mtar closed this Feb 16, 2021
@mtar mtar reopened this Mar 3, 2021
@mtar mtar marked this pull request as ready for review March 11, 2021 10:53
@coquelin77 coquelin77 merged commit 8070fad into master Mar 16, 2021
@coquelin77 coquelin77 deleted the enhancement/721-warnings branch March 16, 2021 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reduce number of warnings in unit tests
2 participants