Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add unary negative / positive + fix deg2rad / rad2deg #768

Merged
merged 3 commits into from May 6, 2021

Conversation

mtar
Copy link
Collaborator

@mtar mtar commented May 4, 2021

Description

implement unary positive and negative operations + fix deg2rad / rad2deg

Issue/s resolved: #763

Changes proposed:

  • add unary +
  • add unary -
  • deg2rad: replace with pytorch function
  • rad2deg: replace with pytorch function
  • add documentation for alias functions in arithmetics.py

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation update

Due Diligence

  • All split configurations tested
  • Multiple dtypes tested in relevant functions
  • Documentation updated (if needed)
  • Updated changelog.md under the title "Pending Additions"

Does this change modify the behaviour of other functions? If so, which?

no

implement unary positive and negative operations + fix deg2rad / rad2deg
@mtar mtar added bug Something isn't working enhancement New feature or request local operator labels May 4, 2021
@codecov
Copy link

codecov bot commented May 4, 2021

Codecov Report

Merging #768 (f018a3a) into master (fb1e4fd) will increase coverage by 0.01%.
The diff coverage is 95.45%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #768      +/-   ##
==========================================
+ Coverage   95.22%   95.23%   +0.01%     
==========================================
  Files          64       64              
  Lines        8728     8739      +11     
==========================================
+ Hits         8311     8323      +12     
+ Misses        417      416       -1     
Flag Coverage Δ
gpu 94.33% <95.45%> (+0.01%) ⬆️
unit 90.70% <95.45%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
heat/core/arithmetics.py 99.05% <95.00%> (-0.43%) ⬇️
heat/core/trigonometrics.py 100.00% <100.00%> (+2.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb1e4fd...f018a3a. Read the comment docs.

@mtar mtar marked this pull request as ready for review May 4, 2021 11:21
@coquelin77 coquelin77 merged commit 341c94d into master May 6, 2021
@coquelin77 coquelin77 deleted the enhancement/763-unary-ops branch May 6, 2021 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request local operator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unary - and + operator
2 participants