Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dot product matrix vector ops + randn inf bugfix #820

Merged
merged 4 commits into from Jul 1, 2021

Conversation

coquelin77
Copy link
Member

Description

dot can multiply matrices and vectors now
randn bug is now hopefully fixed. tested up to memory limit of my personal machine

Issue/s resolved: #817 #819

Changes proposed:

  • dot uses matmul to handle matrix @ vector inputs
  • inputs to kundu transform in randn get a very small offset to move them away from 0. this should avoid the inf values from showing up without changing the distribution very much at all

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Due Diligence

  • All split configurations tested
  • Multiple dtypes tested in relevant functions
  • Documentation updated (if needed)
  • Updated changelog.md under the title "Pending Additions"

Does this change modify the behaviour of other functions? If so, which?

no

@codecov
Copy link

codecov bot commented Jun 23, 2021

Codecov Report

Merging #820 (5e84bd0) into master (83ec24a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #820   +/-   ##
=======================================
  Coverage   95.31%   95.31%           
=======================================
  Files          64       64           
  Lines        9000     9002    +2     
=======================================
+ Hits         8578     8580    +2     
  Misses        422      422           
Flag Coverage Δ
gpu 94.44% <100.00%> (+<0.01%) ⬆️
unit 90.90% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
heat/core/linalg/basics.py 94.35% <100.00%> (ø)
heat/core/random.py 99.64% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83ec24a...5e84bd0. Read the comment docs.

@coquelin77 coquelin77 changed the title Features/817 dot vectors Dot product matrix vector ops + randn inf bugfix Jun 23, 2021
mtar
mtar previously approved these changes Jun 30, 2021
@coquelin77
Copy link
Member Author

@mtar approved this before there was a merge conflict in the changelog. I will merge this now

@coquelin77 coquelin77 merged commit e61391a into master Jul 1, 2021
@coquelin77 coquelin77 deleted the features/817-dot-vectors branch July 1, 2021 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dot product with 2D dot 1D DNDarrays
2 participants