Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement vecdot #840

Merged
merged 9 commits into from
Aug 2, 2021
Merged

implement vecdot #840

merged 9 commits into from
Aug 2, 2021

Conversation

mtar
Copy link
Collaborator

@mtar mtar commented Jul 14, 2021

Description

Implement vecdot, which allows row-wise/column-wise vector dot of matrices.

Issue/s resolved: #838

Changes proposed:

  • add vecdot

Type of change

  • New feature

Due Diligence

  • All split configurations tested
  • Multiple dtypes tested in relevant functions
  • Documentation updated (if needed)
  • Updated changelog.md under the title "Pending Additions"

@codecov
Copy link

codecov bot commented Jul 14, 2021

Codecov Report

Merging #840 (cd6881a) into master (f0afedf) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #840   +/-   ##
=======================================
  Coverage   95.35%   95.35%           
=======================================
  Files          64       64           
  Lines        9125     9130    +5     
=======================================
+ Hits         8701     8706    +5     
  Misses        424      424           
Flag Coverage Δ
gpu 94.50% <100.00%> (+<0.01%) ⬆️
unit 91.00% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
heat/core/linalg/basics.py 94.39% <100.00%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0afedf...cd6881a. Read the comment docs.

@mtar mtar added the API Anything relating the API label Jul 19, 2021
@mtar mtar requested a review from coquelin77 July 20, 2021 06:37
coquelin77
coquelin77 previously approved these changes Aug 2, 2021
@coquelin77 coquelin77 merged commit 50a743a into master Aug 2, 2021
@coquelin77 coquelin77 deleted the enhancement/839-vecdot branch August 2, 2021 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Anything relating the API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

implement vecdot
2 participants