Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vdot implementation #842

Merged
merged 16 commits into from
Oct 8, 2021
Merged

vdot implementation #842

merged 16 commits into from
Oct 8, 2021

Conversation

mtar
Copy link
Collaborator

@mtar mtar commented Jul 19, 2021

Description

vdot implementation

Issue/s resolved: #839

Changes proposed:

  • add vdot function

Type of change

  • New feature

Due Diligence

  • All split configurations tested
  • Multiple dtypes tested in relevant functions
  • Documentation updated (if needed)
  • Updated changelog.md under the title "Pending Additions"

Does this change modify the behaviour of other functions? If so, which?

yes / no

@codecov
Copy link

codecov bot commented Jul 19, 2021

Codecov Report

Merging #842 (49b1c21) into master (300e05e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #842   +/-   ##
=======================================
  Coverage   95.48%   95.48%           
=======================================
  Files          64       64           
  Lines        9454     9459    +5     
=======================================
+ Hits         9027     9032    +5     
  Misses        427      427           
Flag Coverage Δ
gpu 94.61% <100.00%> (+<0.01%) ⬆️
unit 91.01% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
heat/core/linalg/basics.py 94.89% <100.00%> (+0.02%) ⬆️
heat/core/manipulations.py 98.94% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 300e05e...49b1c21. Read the comment docs.

@mtar mtar added the API Anything relating the API label Jul 19, 2021
@mtar mtar requested a review from coquelin77 July 20, 2021 06:37
Copy link
Member

@coquelin77 coquelin77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything looks good here, just one comment

heat/core/linalg/basics.py Show resolved Hide resolved
@ClaudiaComito ClaudiaComito added this to the 1.2.x milestone Aug 18, 2021
@coquelin77
Copy link
Member

conflicts on this branch

Copy link
Contributor

@ClaudiaComito ClaudiaComito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @mtar ! Just a few minor changes needed, this one can be merged soon as far as I'm concerned.

heat/core/linalg/basics.py Outdated Show resolved Hide resolved
heat/core/linalg/basics.py Outdated Show resolved Hide resolved
heat/core/linalg/basics.py Outdated Show resolved Hide resolved
@mtar mtar requested a review from coquelin77 October 6, 2021 09:28
@coquelin77 coquelin77 merged commit d853605 into master Oct 8, 2021
@coquelin77 coquelin77 deleted the enhancement/839-vdot branch October 8, 2021 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Anything relating the API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

implement vdot
3 participants