Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

norm implementation #846

Merged
merged 15 commits into from Aug 20, 2021
Merged

norm implementation #846

merged 15 commits into from Aug 20, 2021

Conversation

mtar
Copy link
Collaborator

@mtar mtar commented Jul 27, 2021

Description

Rewrite of norm to support more types of norms.

Issue/s resolved: #836 #845 #847

Changes proposed:

  • add norm, vector_norm, matrix_norm
  • fix bug reduce_op with axis and keepdim
  • dot returns a 0-dim array instead of builtin float
  • fix bug in max/min (_reduce_op) on distributed arrays.

Type of change

  • New feature
  • Bug fix

Due Diligence

  • All split configurations tested
  • Multiple dtypes tested in relevant functions
  • Documentation updated (if needed)
  • Updated changelog.md under the title "Pending Additions"

Does this change modify the behaviour of other functions? If so, which?

no

@mtar mtar marked this pull request as draft July 27, 2021 13:40
@codecov
Copy link

codecov bot commented Jul 28, 2021

Codecov Report

Merging #846 (26a9eef) into master (634a2bd) will increase coverage by 0.03%.
The diff coverage is 98.96%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #846      +/-   ##
==========================================
+ Coverage   95.37%   95.40%   +0.03%     
==========================================
  Files          64       64              
  Lines        9162     9246      +84     
==========================================
+ Hits         8738     8821      +83     
- Misses        424      425       +1     
Flag Coverage Δ
gpu 94.55% <98.96%> (+0.03%) ⬆️
unit 91.10% <98.96%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
heat/core/linalg/basics.py 94.86% <98.92%> (+0.46%) ⬆️
heat/core/_operations.py 95.76% <100.00%> (+0.02%) ⬆️
heat/core/linalg/solver.py 69.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 634a2bd...26a9eef. Read the comment docs.

@mtar mtar marked this pull request as ready for review July 28, 2021 08:09
@mtar mtar requested a review from coquelin77 July 28, 2021 08:09
@mtar mtar changed the title Enhancement/836 norm norm implementation Jul 28, 2021
heat/core/_operations.py Show resolved Hide resolved
heat/core/linalg/basics.py Show resolved Hide resolved
@ClaudiaComito ClaudiaComito added this to the 1.2.x milestone Aug 18, 2021
@coquelin77 coquelin77 merged commit e0af0e5 into master Aug 20, 2021
@coquelin77 coquelin77 deleted the enhancement/836-norm branch August 20, 2021 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

min + max on a not fully distributed array reduction_op with axis + keepdim improve linalg.norm
3 participants