Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add moveaxis #854

Merged
merged 6 commits into from
Aug 20, 2021
Merged

add moveaxis #854

merged 6 commits into from
Aug 20, 2021

Conversation

mtar
Copy link
Collaborator

@mtar mtar commented Jul 30, 2021

Description

Implementation of moveaxis that calls transpose internally for computation.

Issue/s resolved: #848

Changes proposed:

  • add moveaxis

Type of change

  • New Feature

Due Diligence

  • All split configurations tested
  • Multiple dtypes tested in relevant functions
  • Documentation updated (if needed)
  • Updated changelog.md under the title "Pending Additions"

Does this change modify the behaviour of other functions? If so, which?

no

@codecov
Copy link

codecov bot commented Jul 30, 2021

Codecov Report

Merging #854 (638a172) into master (86413ff) will increase coverage by 4.35%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #854      +/-   ##
==========================================
+ Coverage   91.00%   95.36%   +4.35%     
==========================================
  Files          64       64              
  Lines        9130     9153      +23     
==========================================
+ Hits         8309     8729     +420     
+ Misses        821      424     -397     
Flag Coverage Δ
gpu 94.51% <100.00%> (?)
unit 91.03% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
heat/core/manipulations.py 99.06% <100.00%> (+0.01%) ⬆️
heat/core/dndarray.py 97.30% <0.00%> (+0.28%) ⬆️
heat/core/factories.py 100.00% <0.00%> (+0.75%) ⬆️
heat/core/statistics.py 97.60% <0.00%> (+0.85%) ⬆️
heat/core/linalg/basics.py 94.39% <0.00%> (+1.58%) ⬆️
heat/utils/data/partial_dataset.py 94.35% <0.00%> (+2.05%) ⬆️
heat/core/tests/test_suites/basic_test.py 96.11% <0.00%> (+4.85%) ⬆️
heat/core/communication.py 96.73% <0.00%> (+6.90%) ⬆️
heat/nn/data_parallel.py 94.48% <0.00%> (+10.34%) ⬆️
heat/core/devices.py 97.77% <0.00%> (+11.11%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86413ff...638a172. Read the comment docs.

Copy link
Contributor

@ClaudiaComito ClaudiaComito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for this. Just one change request as far as I'm concerned.

@ClaudiaComito ClaudiaComito added this to the 1.2.x milestone Aug 18, 2021
@coquelin77
Copy link
Member

looks good to me and @ClaudiaComito 's changes have been addressed. im going to merge this

@coquelin77 coquelin77 merged commit e7c13c6 into master Aug 20, 2021
@coquelin77 coquelin77 deleted the feature/848-moveaxis branch August 20, 2021 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

implement moveaxis
3 participants