Features/torch proxy #856
Merged
Features/torch proxy #856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClaudiaComito
added this to In progress
in Internal overhaul `ht.array()` --> `DNDarray()`
via automation
Codecov Report
@@ Coverage Diff @@
## master #856 +/- ##
==========================================
+ Coverage 95.40% 95.45% +0.05%
==========================================
Files 64 64
Lines 9380 9382 +2
==========================================
+ Hits 8949 8956 +7
+ Misses 431 426 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
ClaudiaComito
requested review from
coquelin77,
mtar,
ben-bou and
Markus-Goetz
|
rerun tests |
coquelin77
approved these changes
Aug 23, 2021
Internal overhaul `ht.array()` --> `DNDarray()`
automation
moved this from In progress
to Reviewer approved
Aug 23, 2021
Internal overhaul `ht.array()` --> `DNDarray()`
automation
moved this from Reviewer approved
to Done
Aug 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I propose to implement a DNDarray method to return a 1-byte
torch.Tensorstrided as the original DNDarray global shape. At @ben-bou 's suggestion, we have been using this "proxy" tensor for sanitation, as it allows us to easily bypass many of the instance checks. It is also quite practical to assess the shape of the output DNDarray of any operation. See getitem/setitem, ormanipulations.tile()for examples.Issue/s resolved: None. Implemented with an eye on long-term maintenance / minimizing repetitions / simplifying code.
Changes proposed:
DNDarray.__torch_proxy__()dndarrayandmanipulationswithDNDarray.__torch_proxy__()callsDNDarray.sizereturninginteven ifDNDarray.ndimis 0Type of change
Due Diligence
Does this change modify the behaviour of other functions? If so, which?
no