Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add signbit #862

Merged
merged 4 commits into from
Sep 16, 2021
Merged

add signbit #862

merged 4 commits into from
Sep 16, 2021

Conversation

mtar
Copy link
Collaborator

@mtar mtar commented Aug 27, 2021

Description

Implementation of signbit

Issue/s resolved: #861

Changes proposed:

  • signbit

Type of change

  • New feature

Due Diligence

  • All split configurations tested
  • Multiple dtypes tested in relevant functions
  • Documentation updated (if needed)
  • Updated changelog.md under the title "Pending Additions"

Does this change modify the behaviour of other functions? If so, which?

no

@codecov
Copy link

codecov bot commented Aug 27, 2021

Codecov Report

Merging #862 (37eae3d) into master (631f113) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #862   +/-   ##
=======================================
  Coverage   95.46%   95.46%           
=======================================
  Files          64       64           
  Lines        9396     9398    +2     
=======================================
+ Hits         8970     8972    +2     
  Misses        426      426           
Flag Coverage Δ
gpu 94.63% <100.00%> (+<0.01%) ⬆️
unit 91.24% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
heat/core/logical.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 631f113...37eae3d. Read the comment docs.

@coquelin77 coquelin77 merged commit 9db0a93 into master Sep 16, 2021
@coquelin77 coquelin77 deleted the feature/861-signbit branch September 16, 2021 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

implement signbit
2 participants