Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

conjugate method in DNDarray #885

Merged
merged 3 commits into from Nov 9, 2021
Merged

Conversation

mtar
Copy link
Collaborator

@mtar mtar commented Oct 28, 2021

Description

Adds conj to DNDarray to match the NumPy/PyTorch API

Changes proposed:

  • DNDarray method conj

Type of change

  • Enhancement/feature

Memory requirements

N/A 馃槂

Performance

N/A 馃槂

Due Diligence

  • All split configurations tested
  • Multiple dtypes tested in relevant functions
  • Documentation updated (if needed)
  • Updated changelog.md under the title "Pending Additions"

Does this change modify the behaviour of other functions? If so, which?

no

@mtar mtar added the API Anything relating the API label Oct 28, 2021
@codecov
Copy link

codecov bot commented Oct 28, 2021

Codecov Report

Merging #885 (fe05e9e) into master (ef32ccf) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #885   +/-   ##
=======================================
  Coverage   95.47%   95.47%           
=======================================
  Files          64       64           
  Lines        9533     9535    +2     
=======================================
+ Hits         9102     9104    +2     
  Misses        431      431           
Flag Coverage 螖
gpu 94.61% <100.00%> (+<0.01%) 猬嗭笍
unit 91.04% <100.00%> (+<0.01%) 猬嗭笍

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage 螖
heat/core/complex_math.py 100.00% <100.00%> (酶)

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update ef32ccf...fe05e9e. Read the comment docs.

@mtar mtar changed the title Enhancement/conjugate method conjugate method in DNDarray Oct 28, 2021
Copy link
Member

@coquelin77 coquelin77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well that was easy! 馃榿

@coquelin77 coquelin77 merged commit 3db3877 into master Nov 9, 2021
@coquelin77 coquelin77 deleted the enhancement/conjugate-method branch November 9, 2021 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Anything relating the API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants