Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features/537 better inclusion of license file #894

Merged
merged 7 commits into from Jan 4, 2022

Conversation

bhagemeier
Copy link
Member

@bhagemeier bhagemeier commented Dec 8, 2021

Description

This PR changes several two aspects of installing and using HeAT.

  1. get rid of README.md and LICENSE files in the install root / PREFIX
  2. make the already packaged data sets available as a package resource

Issue/s resolved: #537

Changes proposed:

Type of change

  • Bug fix
  • New feature

Memory requirements

n/a

Performance

n/a

Due Diligence

  • All split configurations tested
  • Multiple dtypes tested in relevant functions
  • Documentation updated (if needed)
  • Updated changelog.md under the title "Pending Additions"

Does this change modify the behaviour of other functions? If so, which?

no

skip ci

This led to the files being installed in the Python environment's root directory.
This allows for using them from examples as long as there is an installed Heat package.
This allows for using them from examples as long as there is an installed Heat package.
…b.com:helmholtz-analytics/heat into features/537-better-inclusion-of-license-file
@codecov
Copy link

codecov bot commented Dec 8, 2021

Codecov Report

Merging #894 (5c9a0aa) into master (d450103) will decrease coverage by 4.44%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #894      +/-   ##
==========================================
- Coverage   95.49%   91.04%   -4.45%     
==========================================
  Files          64       64              
  Lines        9535     9535              
==========================================
- Hits         9105     8681     -424     
- Misses        430      854     +424     
Flag Coverage Δ
gpu ?
unit 91.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
heat/optim/dp_optimizer.py 24.19% <0.00%> (-71.89%) ⬇️
heat/core/devices.py 86.66% <0.00%> (-11.12%) ⬇️
heat/nn/data_parallel.py 84.13% <0.00%> (-10.35%) ⬇️
heat/cluster/spectral.py 85.71% <0.00%> (-8.58%) ⬇️
heat/core/communication.py 89.90% <0.00%> (-6.86%) ⬇️
heat/core/tests/test_suites/basic_test.py 91.26% <0.00%> (-4.86%) ⬇️
heat/core/linalg/qr.py 97.30% <0.00%> (-2.70%) ⬇️
heat/utils/data/partial_dataset.py 92.30% <0.00%> (-2.06%) ⬇️
heat/core/linalg/basics.py 93.48% <0.00%> (-1.41%) ⬇️
heat/core/rounding.py 95.95% <0.00%> (-1.02%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d450103...5c9a0aa. Read the comment docs.

@bhagemeier bhagemeier marked this pull request as ready for review December 8, 2021 20:51
Copy link
Member

@coquelin77 coquelin77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very cool. thanks for the fix

@coquelin77
Copy link
Member

this is only failing because the CI is not running on the GPUs. However, this PR does not do any calculation, thus it does not require the tests to run there. I will merge this

@coquelin77 coquelin77 merged commit bc74848 into master Jan 4, 2022
@coquelin77 coquelin77 deleted the features/537-better-inclusion-of-license-file branch January 4, 2022 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better inclusion of license file
2 participants