Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features/384 sparse matrices #988

Closed
wants to merge 9 commits into from
Closed

Conversation

AmirTouilPU
Copy link
Collaborator

@AmirTouilPU AmirTouilPU commented Jul 11, 2022

Description

New class: coo_matrix:

coo_matrix class (should be re-named to coo_array). Indices are calculated using a function in the class file

Issue/s resolved:

  • coo_indices are now working
  • gshape calculation from a torch.sparse_coo_tensor in the test.py file: turnt the shape to tuple (couldn't modify the tuple), then to a list, changed the gshape[split] value, then turnt it to a tuple again.

Does this change modify the behaviour of other functions? If so, which?

Should the function indices be part of the class?

@ghost
Copy link

ghost commented Jul 11, 2022

👇 Click on the image for a new way to code review
  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

@ClaudiaComito
Copy link
Contributor

Following

@ClaudiaComito ClaudiaComito added enhancement New feature or request sparse labels Oct 5, 2022
@ClaudiaComito ClaudiaComito added this to the Repo Clean-Up milestone Jul 31, 2023
@ClaudiaComito
Copy link
Contributor

closing this as it is unfinished. Happy to reopen if somebody else wants to work on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request sparse
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants