fix(core): BrowserAnimationsModule is optional dependency now #1377 #2054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
|
According to test results It seems like this actually perfectly reproduces original issue brought up in #1377 😄 |
satanTime
force-pushed
the
issues/1377
branch
2 times, most recently
from
ff983fb
to
5666df4
Compare
satanTime
changed the title
satanTime
force-pushed
the
issues/1377
branch
8 times, most recently
from
9124bae
to
fd67209
Compare
…-mom#1377 Please add `ngMocks.globalReplace(BrowserAnimationsModule, NoopAnimationsModule);` if you need the old behavior.
|
v13.4.0 has been released and contains a fix for the issue. Feel free to reopen the issue or to submit a new one if you meet any problems. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1377