#42: Issue with Animations Library #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satanTime
force-pushed
the
feature/ISSUE-42
branch
3 times, most recently
from
a1d30bf
to
2b43c2f
Compare
ike18t
reviewed
Jan 28, 2019
lib/mock-module/mock-module.ts
Outdated
| if (typeof provide === 'function' && provide.name === 'ApplicationInitStatus') { | ||
| return undefined; | ||
| } | ||
| if (typeof provide === 'function' && provide.name === 'DomRendererFactory2') { |
There was a problem hiding this comment.
Do you mind squashing the conditionals into one?
Suggested change
| if (typeof provide === 'function' && provide.name === 'DomRendererFactory2') { | |
| if (typeof provide === 'function' && ['ApplicationInitStatus', 'DomRendererFactory2', ' RendererFactory2'].includes(provide.name) { |
Added more flexible way to detect system provides, which we shouldn't mock / replace.
satanTime
force-pushed
the
feature/ISSUE-42
branch
from
2b43c2f
to
34cd83f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added more flexible way to detect system provides, which we shouldn't mock / replace.