Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Griefprevention softmute not working #211

Closed
Smudgge opened this issue Jun 21, 2023 · 8 comments
Closed

Griefprevention softmute not working #211

Smudgge opened this issue Jun 21, 2023 · 8 comments

Comments

@Smudgge
Copy link
Contributor

Smudgge commented Jun 21, 2023

ChatChat: #65
Server Version: 1.19.4
Grief Prevention: 16.18.1

I had a look though the code but I could not find why the new grief prevention code is not working.

Same as before, when you softmute a player, players are still able to see what they are saying.

@Smudgge Smudgge changed the title Griefprevention softmute not working. Griefprevention softmute not working Jun 21, 2023
@BlitzOffline
Copy link
Member

BlitzOffline commented Jun 21, 2023

You have to go to plugins/ChatChat/extensions.yml and enable the griefprevention soft mute extension. Let me know if it still isn't working after that.

@Smudgge
Copy link
Contributor Author

Smudgge commented Jun 21, 2023

addons:
  deluxechat:
    inverse_priorities: true
    unicode_permission:
      public_chat: true
      private_chat: true
  towny:
    channels: false
  discordsrv:
    channels_bridging: false
  essentials:
    vanish: false
  supervanish:
    vanish: true
    soft_mute: false
  griefprevention:
    soft_mute: true

We have softmute set to true but still doesn't work.

Screenshot 2023-06-21 at 10 04 57 pm
IMG-20230621-WA00032

@BlitzOffline
Copy link
Member

Just making sure but have you restarted the server after toggling it to true? Any changes in extensions.yml require a restart to apply.

@Smudgge
Copy link
Contributor Author

Smudgge commented Jun 22, 2023

I think we have found the issue, when you reload the plugin the config regenerates like this :

addons:
  deluxechat:
    inverse_priorities: false
    unicode_permission:
      public_chat: true
      private_chat: true
  towny:
    channels: false
  discordsrv:
    channels_bridging: false
  essentials:
    vanish: false
  supervanish:
    vanish: false
    soft_mute: true

Maybe you could look though the code, may be related to why softmute is not working

@Smudgge
Copy link
Contributor Author

Smudgge commented Jun 22, 2023

Screenshot 2023-06-22 at 10 22 38 am
Ahh found it!

@Smudgge
Copy link
Contributor Author

Smudgge commented Jun 22, 2023

Made fix here #212

@BlitzOffline
Copy link
Member

Ah. Good catch. Tested everything but right before finishing that PR I've made some changes that I didn't test and I guess somehow I managed to forget to change something when copy pasting the changes.

@BlitzOffline
Copy link
Member

Fixed in #212

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants