Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GIF Support #20

Merged
merged 2 commits into from
Jun 9, 2020
Merged

GIF Support #20

merged 2 commits into from
Jun 9, 2020

Conversation

ScottPetit
Copy link
Contributor

So in working on IOSSDK-93 I found that it seems like HSAttachmentPicker doesn't really support GIFs. Primarily this seems like the data that we pass to HSAttachmentPickerDelegate

- (void)attachmentPickerMenu:(HSAttachmentPicker *_Nonnull)menu upload:(NSData *_Nonnull)data filename:(NSString *_Nonnull)filename image:(UIImage *_Nullable)image;

is just the JPEG representation of the UIImage that we get back from the picker. Now HSAttachmentPicker requests the imageData from the Photos framework and passes back that result to the HSAttachmentPickerDelegate.

Also of note, testing this with the current HSAttachmentPicker setup is kinda impossible so I'm kinda hoping that it just works when taking into the Beacon SDK and then maybe we CANI updating this project to match our other setups

Copy link
Contributor

@samsymons samsymons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@samsymons samsymons merged commit 8be14b9 into master Jun 9, 2020
@samsymons samsymons deleted the feature/gif-support branch June 9, 2020 15:24
Copy link
Contributor

@codenameDuchess codenameDuchess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants