Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So in working on IOSSDK-93 I found that it seems like HSAttachmentPicker doesn't really support GIFs. Primarily this seems like the data that we pass to
HSAttachmentPickerDelegate
is just the JPEG representation of the UIImage that we get back from the picker. Now
HSAttachmentPicker
requests theimageData
from thePhotos
framework and passes back that result to theHSAttachmentPickerDelegate
.Also of note, testing this with the current HSAttachmentPicker setup is kinda impossible so I'm kinda hoping that it just works when taking into the Beacon SDK and then maybe we CANI updating this project to match our other setups