ThemeProvider: Add nesting support #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This update adds nesting support to `ThemeProvider`, allowing you to continously add onto the outer/parent Theme as required. The `scope` feature was also abstracted from `ThemeProvider` into a dedicated `ScopeProvider`. How it influences the compiled CSS remains the same. Internally, the `StyleSheet` class instantiation has been changed into a factory to produces a Singleton, used throughout the Providers and `styled`.
|
Note: Add additional coverage for |
Pull Request Test Coverage Report for Build 115
馃挍 - Coveralls |
added 4 commits
June 29, 2018 11:15
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ThemeProvider: Add nesting support 馃枌
This update adds nesting support to
ThemeProvider, allowing you tocontinously add onto the outer/parent Theme as required.
The
scopefeature was also abstracted fromThemeProviderinto a dedicatedScopeProvider. How it influences the compiled CSS remains the same.Internally, the
StyleSheetclass instantiation has been changed into afactory to produces a Singleton, used throughout the Providers and
styled.