Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polyfill WeakMap for IE11 #37

Merged
merged 3 commits into from
Jan 17, 2019
Merged

Polyfill WeakMap for IE11 #37

merged 3 commits into from
Jan 17, 2019

Conversation

ItsJonQ
Copy link
Contributor

@ItsJonQ ItsJonQ commented Jan 17, 2019 •
edited
Loading

Polyfill WeakMap for IE11

This update polyfills Weakmap with a lightweight implementation from Google.

Replace WeakMap with object
563004f 
This update replaces the WeakMap with a regular Object for the cache within
`create-emotion` core. This is to improve IE11 support without adding a (bloated)
polyfill.
@ItsJonQ ItsJonQ added the enhancement New feature or request label Jan 17, 2019
@ItsJonQ ItsJonQ self-assigned this Jan 17, 2019
@ItsJonQ ItsJonQ requested a review from Charca January 17, 2019 13:49
@coveralls
Copy link

coveralls commented Jan 17, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 215

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 213: 0.0%
Covered Lines: 73
Relevant Lines: 73
💛 - Coveralls

@ItsJonQ ItsJonQ changed the title Replace WeakMap with object Polyfill WeakMap for IE11 Jan 17, 2019
@ItsJonQ ItsJonQ merged commit 7def3f7 into master Jan 17, 2019
ItsJonQ pushed a commit that referenced this pull request Jan 17, 2019
Revert "Polyfill WeakMap for IE11 (#37)"
296d931 
This reverts commit 7def3f7.
@ItsJonQ ItsJonQ mentioned this pull request Jan 17, 2019
Merged
ItsJonQ pushed a commit that referenced this pull request Jan 17, 2019
Revert "Polyfill WeakMap for IE11 (#37)" (#38)
786b79a 
This reverts commit 7def3f7.
@ItsJonQ ItsJonQ deleted the weakmap-replace branch April 30, 2019 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Charca Charca Awaiting requested review from Charca

Assignees

@ItsJonQ ItsJonQ

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ItsJonQ @coveralls