Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix emotion compiling #41

Merged
merged 1 commit into from
Mar 5, 2019
Merged

Fix emotion compiling #41

merged 1 commit into from
Mar 5, 2019

Conversation

ItsJonQ
Copy link
Contributor

@ItsJonQ ItsJonQ commented Mar 5, 2019

Fix emotion compiling

This update resolves how Emotion is compiled by reverting back
@helpscout/zero back to v0.0.9.

The older version of @helpscout/zero uses babel-6, along with different
.babelrc configs. This seems to play nicer with Emotion.

This has been manually tested with beacon-2.

This update resolves how Emotion is compiled by reverting back
`@helpscout/zero` back to v0.0.9.

The older version of `@helpscout/zero` uses babel-6, along with different
`.babelrc` configs. This seems to play nicer with Emotion.

This has been manually tested with beacon-2.
@ItsJonQ ItsJonQ added the bug Something isn't working label Mar 5, 2019
@ItsJonQ ItsJonQ self-assigned this Mar 5, 2019
@ItsJonQ ItsJonQ requested a review from Charca March 5, 2019 22:27
@ItsJonQ ItsJonQ merged commit 5999d2e into master Mar 5, 2019
@coveralls
Copy link

Pull Request Test Coverage Report for Build 226

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 224: 0.0%
Covered Lines: 73
Relevant Lines: 73

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants