Drop deepClone for speed boost!

helpscout · Nov 2, 2017 · 4b326d7 · 4b326d7
1 parent 6d9595f
commit 4b326d7
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/src/Spec/index.js b/src/Spec/index.js
@@ -1,6 +1,5 @@
 import faker from 'faker'
 import {
-  cloneDeep,
   isArray,
   isFunction,
   isNumber,
@@ -58,10 +57,10 @@ class HelixSpec {
  * @returns object
  */
 const generateSpecs = (shape) => {
-  return mapValues(cloneDeep(shape), (value, key) => {
+  return mapValues(shape, (value, key) => {
     // Preserve array structures
     if (isArray(value)) {
-      return value.map(v => generateSpecs(v))
+      return value.map(val => generateSpecs(val))
     }
     // Recurse
     if (isObject(value) && !isFunction(value)) {

diff --git a/src/faker/index.js b/src/faker/index.js
@@ -1,4 +1,4 @@
-import { cloneDeep, isObject, isFunction, mapValues } from 'lodash'
+import { isObject, isFunction, mapValues } from 'lodash'
 import fakerLib from 'faker'
 
 /**
@@ -26,7 +26,7 @@ const remapFakerObject = (object) => {
  * Clones/enhances the Faker object
  * @returns object
  */
-const faker = remapFakerObject(cloneDeep(fakerLib))
+const faker = remapFakerObject(Object.assign({}, fakerLib))
 
 // Required to mention Faker functionality
 faker.seed = (...args) => fakerLib.seed(...args)